Unified KeyType API for multi-chain keyring with ICA HostKeyName support#12
Merged
Unified KeyType API for multi-chain keyring with ICA HostKeyName support#12
Conversation
Contributor
akobrin1
commented
Feb 14, 2026
akobrin1
commented
- Added KeyType enum (KeyTypeCosmos, KeyTypeEVM) that encapsulates key algorithm, BIP44 HD path, and signing algo selection in one place
- Unified keyring functions into NewKeyring, LoadKeyring, and ImportKey — a single keyring now supports both secp256k1 and eth_secp256k1 key types, with the algorithm chosen at import time
- Removed redundant wrappers (NewKeyringEVM, LoadKeyringFromMnemonic, LoadKeyringFromMnemonicEVM, ImportKeyFromMnemonic, ImportKeyFromMnemonicEVM, NewMultiChainKeyring)
- Added HostKeyName to ICA Config so controller and host chains can use independent key types
- Extracted ICA types, constants, and errors into ica/types.go with doc comments
- Updated documentation (README, API.md, DEVELOPER_GUIDE.md) with KeyType usage, ICA controller overview, strengths/limitations, and comparison with interchaintest
- Added comprehensive unit tests (25 total) covering both key types, error paths, cross-HRP address derivation, and sign/verify round trips
Both previously flagged issues have been addressed. Latest commit (136bbde) is a doc comment fix only -- no new issues found.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR introduces a unified multi-chain keyring API that simplifies key management across Cosmos and EVM-compatible chains. The main improvement is consolidating multiple chain-specific functions into a single keyring that supports both secp256k1 (Cosmos) and eth_secp256k1 (EVM) key types, with the algorithm selected at import time via a KeyType parameter.
Changes:
- Introduced
KeyTypeenum (KeyTypeCosmos, KeyTypeEVM) encapsulating algorithm, BIP44 HD path, and signing algo in one abstraction - Unified keyring functions:
NewKeyring,LoadKeyring, andImportKeynow support both key types through explicitKeyTypeparameters - Removed redundant multi-chain wrappers (NewMultiChainKeyring, LoadKeyringFromMnemonicEVM, ImportKeyFromMnemonicEVM, etc.)
- Extended ICA Config with
HostKeyNamefield to support independent controller/host key types - Extracted ICA types, constants, and errors into
ica/types.gofor better organization - Updated all documentation and added 25 comprehensive unit tests covering both key types, error paths, and cross-chain scenarios
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/crypto/multichain_keyring.go | Deleted - functionality consolidated into unified NewKeyring |
| pkg/crypto/keyring.go | Added KeyType enum and unified NewKeyring/LoadKeyring/ImportKey functions supporting both Cosmos and EVM keys; removed redundant chain-specific wrappers |
| pkg/crypto/crypto_test.go | Added 25 comprehensive tests for KeyType methods, unified keyring functions, multi-chain scenarios, error paths, and sign/verify round trips |
| ica/types.go | New file extracting Config, Controller struct, constants, and error definitions from controller.go with improved documentation |
| ica/controller.go | Integrated HostKeyName support, using it for host chain operations while KeyName signs controller chain transactions |
| examples/ica-request-verify/main.go | Migrated from NewMultiChainKeyring to NewKeyring with KeyringParams |
| examples/ica-request-tx/main.go | Migrated from NewMultiChainKeyring to NewKeyring with KeyringParams |
| docs/DEVELOPER_GUIDE.md | Added comprehensive Crypto Helpers section and ICA Controller Overview with strengths/limitations and comparison with interchaintest |
| docs/API.md | Added pkg/crypto and ica package API documentation with KeyType details and HostKeyName usage |
| README.md | Updated crypto helpers section with KeyType enum, unified functions, and multi-chain key usage examples |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.